Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing permission errors, fixed password bug with default user #167

Merged
merged 16 commits into from
May 10, 2019
Merged

Fixing permission errors, fixed password bug with default user #167

merged 16 commits into from
May 10, 2019

Conversation

jennyowen
Copy link
Member

  • Stopped Neo4j from granting read/write permissions to all on mounted folders. It will still change the folder owner if the docker container is not started using the --user flag though (for backwards compatibility).
  • Improved warning messages when mounting folders.
  • Added helpful error message for when mounting folders fails, including troubleshooting tips.
  • Refactored tests and added a few new test cases I encountered

includes PR #165
Hopefully fixes:
#164
#130

As I was making changes I noticed a bug when setting passwords that occurs when running docker without --user flag. I fixed that too (hopefully).
I believe this may also solve #147 and #163

rweverwijk and others added 16 commits March 21, 2019 12:51
@rweverwijk
change default permissions to 750 for folders, 640 for files
e3fe4c7
@rweverwijk
replaced chown and chmod with checks for writable directories
d981f49
@rweverwijk
make sure all directories are checked
a4069f5
@rweverwijk
make sure the set-initial-password command is executed as the user ru…
3851973 
…nning
@rweverwijk
make sure that if volume is provided the rights are correct
c90c43b
@rweverwijk
chmod NEO4J_HOME back to previous
b1b1d34
@rweverwijk
fix rights provided volumes
9ff9a53
@jennyowen
Merge pull request #165 from rweverwijk/master
3ee6400 
Docker entrypoint should not chmod or chown folders
@jennyowen
commiting wip
0c879fb
@jennyowen
more wip
ab33668
@jennyowen
fixed chowning of mounted folders.
be1c1b8
@jennyowen
fixed bug in setting password and refactored tests slightly
046f850
@jennyowen
more refactoring of tests
1fd0100
@jennyowen
patched 3.5 fixes to earlier releases 3.3 and 3.4
b43c4c6
@jennyowen
disabling password stderr check for versions 3.2 and earlier
038020f
@jennyowen
fixed mistake in passwords tests
bc50a56
This was referenced May 10, 2019
Closed
Closed
@jennyowen jennyowen merged commit b023095 into master May 10, 2019
@jennyowen jennyowen deleted the chownership branch May 13, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennyowen @rweverwijk