Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessions for self-managed dbms docs (manual + notebook) #719

Merged
merged 16 commits into from
Aug 27, 2024

Conversation

FlorentinD
Copy link
Contributor

based on #712

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for neo4j-graph-data-science-client canceled.

Name Link
🔨 Latest commit a98afbd
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-graph-data-science-client/deploys/66cd940d781c9000081add2f

@FlorentinD FlorentinD force-pushed the dedicated-sessions-notebook branch 2 times, most recently from 786712c to 261b3c7 Compare August 26, 2024 08:21
@FlorentinD FlorentinD marked this pull request as ready for review August 26, 2024 09:46
tox.ini Outdated Show resolved Hide resolved
@FlorentinD FlorentinD force-pushed the dedicated-sessions-notebook branch 2 times, most recently from efb14d8 to 2d07539 Compare August 26, 2024 12:54
Copy link
Contributor

@DarthMax DarthMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I added a couple of suggestions

doc/modules/ROOT/pages/gds-session.adoc Show resolved Hide resolved
doc/modules/ROOT/pages/tutorials/gds-sessions.adoc Outdated Show resolved Hide resolved
examples/gds-sessions-self-managed.ipynb Outdated Show resolved Hide resolved
examples/gds-sessions-self-managed.ipynb Outdated Show resolved Hide resolved
examples/gds-sessions-self-managed.ipynb Outdated Show resolved Hide resolved
examples/gds-sessions-self-managed.ipynb Outdated Show resolved Hide resolved
examples/gds-sessions-self-managed.ipynb Outdated Show resolved Hide resolved
examples/gds-sessions-self-managed.ipynb Outdated Show resolved Hide resolved
examples/gds-sessions-self-managed.ipynb Outdated Show resolved Hide resolved
@DarthMax DarthMax mentioned this pull request Aug 27, 2024
@FlorentinD FlorentinD merged commit 66c80f7 into neo4j:main Aug 27, 2024
9 checks passed
@FlorentinD FlorentinD deleted the dedicated-sessions-notebook branch August 27, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants