Deprecate query direction options #5694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 43f6276 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I'm adding some integration test coverage, right now! |
angrykoala
approved these changes
Oct 24, 2024
packages/graphql/tests/tck/undirected-relationships/query-direction-aggregations.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
DEFAULT_DIRECTED/DEFAULT_UNDIRECTEDDIRECTED_ONLY/UNDIRECTED_ONLYas@relationship.queryDirectionargument values. The options with the prefixDEFAULTare deprecated following the deprecation of the generateddirectedargument. The options with the suffix_ONLYhave been changed toDIRECTED/UNDIRECTEDas the suffix_ONLY.This PR also adds warnings in case a deprecated value is used.
Less important changes:
getCypherDirection,getRelationshipDirection).