Fix incorrect NDC version in capabilities #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version being returned from the capabilities endpoint is invalid. It currently returns a semver range, which violates the NDC Spec; it should return the semver version number of the NDC spec that the connector speaks.
Since this connector uses the NDC TypeScript SDK v4.4.0, that means it speaks NDC Spec v0.1.2. The capabilities response has been updated to reflect that.
The current version of the Hasura engine will accept the incorrect version, but future versions of the Hasura engine will eventually reject incorrect version numbers, so fixing it is a good thing. 🙂