Fail fast for more rediscovery failures #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
reviewed
Oct 27, 2022
packages/bolt-connection/src/connection-provider/connection-provider-routing.js
Outdated
Show resolved
Hide resolved
bigmontz
force-pushed
the
5.x-fast-failing-on-wrong-imp
branch
from
5d90636 to
bd5e8d9
Compare
bigmontz
changed the title
AndyHeap-NeoTech
approved these changes
Nov 24, 2022
|
Re-triggered the CI after the TestKit PR has been merged ⏳ |
…r' failure When trying to impersonate an invalid user, the routing procedure returns `Neo.ClientError.Statement.ArgumentError`. This type of failure is not in the fail fast list, thus this is wrapped up in the generic rediscovery error triggering the retry in the transaction functions. Since this kind of error is not recoverable, retrying on it is not need and desirable. Then, failing fast on `Neo.ClientError.Statement.ArgumentError` failures speeds up the error bubbling and avoids unnecessary load in the client and server.
bigmontz
force-pushed
the
5.x-fast-failing-on-wrong-imp
branch
from
23ee1bf to
1703009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to impersonate an invalid user, the routing procedure returns
Neo.ClientError.Statement.ArgumentError. This type of failure is not in the fail fast list, thus this is wrapped up in the generic rediscovery error triggering the retry in the transaction functions. Since this kind of error is not recoverable, retrying on it is not need and desirable.Then, failing fast on
Neo.ClientError.Statement.ArgumentErrorfailures speeds up the error bubbling and avoids unnecessary load in the client and server.Other rediscovery failures to be fast failed are:
Neo.ClientError.Statement.TypeErrorNeo.ClientError.Request.Invalid