@Labels setter is not called when loading entity

[jdorleans]

Expected Behavior

Whenever loading an entity, OGM should call (or at least have the option to) @Labels setter property.

Current Behavior

This seems to be a regression and @Labels setter is not called anymore.

Possible Solution

IDK

Steps to Reproduce (for bugs)

Please, check a simple example I've created on my fork: jdorleans@7db1454

Context

In many cases I wanna represent transient fields in my domain as Labels. For that I need to:

1. update labels whenever the transient field changes
2. update the transient field back to its state when the labels are loaded from the DB

However, it seems the current version of OGM does not call setter for labels anymore. As a result, all transient fields of my domain are no longer updated.

Your Environment

• OGM Version used: 3.0.0
• Java Version used: 1.8
• Neo4J Version used: 3.2
• Bolt Driver Version used (if applicable):
• Operating System and Version: Ubuntu and Mac
• Link to your project: jdorleans@7db1454

[nmervaillie]

There are a couple a changes when migrating from OGM 2.1 to 3.0. One of them is that getters/setters access is not supported anymore.

The docs are not published yet, but should very soon. In the meantime, you can check the migration guide here.

Can you have a look give some feedback please ? Maybe it is something we should improve in the docs.

From what I see in your example, you might be interested in the @PostLoad annotation, which you can use in you entities to do some custom initialization after loading.

[jdorleans]

Thx @nmervaillie I'll check and give some feedback.

[jdorleans]

@PostLoad solves it, but I'm forced to use the annotation at the lowest level. I'd like to have a postLoad() method in my Entity abstraction and just override it whenever needed by its children.

It seems MethodsInfo only runs on declared methods instead of all the hierarchy methods.
Probably that could solve the problem when looking for the annotation. So, instead of calling: cls.getDeclaredMethods() it'd call cls.getMethods(). Not sure if we should create another issue for that.

[frant-hartm]

Ok, that seems like a bug.

[jdorleans]

I can confirm it's definitely a bug. I hope the tests I included in my new PR (#484) will help solve this. Please, check on this test: https://github.com/neo4j/neo4j-ogm/pull/484/files#diff-8af1ea6d5cb8f598b436005e95aeba80R83

[michael-simons]

I'm closing this issue in favor of #516. We don't support setter-semantics anymore and the bug regarding @PostLoad should be tracked separate. Thanks.