OGM returns empty result if query results contains nodes and rels with same native id

[nioertel]

Current Behavior

When using session.query(SomeRelationship.class, "MATCH ... RETURN ...", Map.of()), and the query returns rows which contain nodes and relationships which have the same native ids, OGM does not map them because GraphRowModelMapper passes an additionalNodeFilter which considers all relationships nodes if there is a node in the result with the same native id.
The problem actually only occurs if the node with the clashing native id was returned using pattern comprehension because only then the filter filters it out.

Your Environment

Tested with current state of 3.2.x branch. I have a unit test + fix candidate ready. PR will follow.

[nioertel]

Just adding extract from official Neo4j docs:

The function id() returns a node or a relationship identifier, unique by an object type and a database. Therefore, it is perfectly allowable for id() to return the same value for both nodes and relationships in the same database.

[nioertel]

PR is ready and test is finally also green in the GH actions build. Please let me know when you can release a new OGM verison.

The fix will also have to be merged to the master (4.x).

[nioertel]

Thanks @michael-simons for the super fast reaction. Already found the new release on Maven Central :).

[nioertel]

#953 was merged

[michael-simons]

FYI Niels https://github.com/neo4j/neo4j-ogm-spring/releases/tag/1.0.0