Improving SortOrder API #483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implementing props constructor to init an ASC SortOrder by default - Adding another direction and props constructor for extra flexibility - Creating new methods to facilitate addition of new sort order rules - Implementing unit tests - Writing documentation
meistermeier
pushed a commit
that referenced
this pull request
May 14, 2018
- Implementing props constructor to init an ASC SortOrder by default - Adding another direction and props constructor for extra flexibility - Creating new methods to facilitate addition of new sort order rules - Implementing unit tests - Writing documentation Original pull request: #483 (cherry picked from commit 98c40fe)
meistermeier
added a commit
that referenced
this pull request
May 14, 2018
Part of pull request: #483 (cherry picked from commit 0dd4106)
|
Merged on master with e5b6a2f Thanks for your contribution. |
meistermeier
pushed a commit
that referenced
this pull request
Jun 21, 2018
- Implementing props constructor to init an ASC SortOrder by default - Adding another direction and props constructor for extra flexibility - Creating new methods to facilitate addition of new sort order rules - Implementing unit tests - Writing documentation Original pull request: #483 Backport to 3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Replacing old pull request #438
Motivation and Context
It's a more flexible and java compliant api
How Has This Been Tested?
Using existing test case in addition to new tests
Types of changes
Checklist: