Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cast instead of dynamic invocation for enum map keys. #638

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Use cast instead of dynamic invocation for enum map keys. #638

merged 2 commits into from
Jun 28, 2019

Conversation

michael-simons
Copy link
Collaborator

No description provided.

@michael-simons michael-simons self-assigned this Jun 26, 2019
@michael-simons
Copy link
Collaborator Author

@mattharr Can you please remove the import in line 25 (import java.lang.reflect.InvocationTargetException;), otherwise checkstyle fails. I cannot commit onto your master.

@mattharr
Copy link
Contributor

@michael-simons I removed the import, I didn't see the checkstyle problem, because I'd disabled it for my Maven run - for me the checkstyle rules fail on checking the properties files (no newline at the end), maybe its because I'm on Windows?
Although it does seem a bunch of tests have failed in the Travis build?

@michael-simons
Copy link
Collaborator Author

Builds on our internal CI now @mattharr.
Thanks for your contribution!

@michael-simons michael-simons merged commit a6865d6 into neo4j:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants