GH-643 - Make sure all kinds of enums are correctly identified. #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-simons
added a commit
that referenced
this pull request
Apr 6, 2020
This removes the new API on the AnnotationInfo. This API was very well done and tested, but it increases our surface again and we don’t want that. It’s needed in two places and it’s ok to duplicate it the instantiation there. There’s one signifacant change we’re we check whether the attribute is an enum or not. For comparision: #644
michael-simons
added a commit
that referenced
this pull request
Apr 7, 2020
… enum. This adds `org.neo4j.ogm.annotation.Relationship.Direction` to the `@Relationship` annotation which replaces the String-typed property `direction` on that annotation. The `AnnotationInfo` needs to check now whether it targets an enum or not. We use the same mechanism introduced as in #644. The changes allows for some neat and needed refactoring, especially in the `EntityGraphMapper` and in `ClassInfo`. Co-authored-by: Michael Simons <michael.simons@neo4j.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #643.