Improved e2e tests #1724
Merged
Improved e2e tests #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrhardikjoshi
commented
Sep 24, 2024
| @@ -96,7 +96,7 @@ def handle_incomplete_states! | |||
| return unless incomplete_states.any? | |||
| incomplete_versions = incomplete_states.map(&:migration_id) | |||
| fail MigrationError, <<-MSG | |||
| There are migrations struck in an incomplete states, that could not be fixed automatically: | |||
| There are migrations stuck in an incomplete states, that could not be fixed automatically: | |||
mrhardikjoshi
commented
Sep 24, 2024
| @@ -19,7 +19,6 @@ jobs: | |||
| ruby: [ jruby, ruby-3.2.5 ] | |||
| neo4j: [ 5.22.0 ] | |||
| active_model: [ 7.1.3 ] | |||
| # jruby will fail till bug https://github.com/jruby/jruby-openssl/issues/290 is fixed | |||
There was a problem hiding this comment.
This is resolved now.
klobuczek
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull introduces/changes: