Add configurable list of tags to ignore #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't seem to get a simple string array to work with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #48
This should be pretty easy to implement, I'm drafting this mainly because of style issues.
As of now I'm recycling the
TagDetailmodel but I'm only using the first name, it'd be nice to allow for aliases when ignoring but it could get a bit cluttered and I'm pretty sure it wouldn't be possible with simple bindings; on the other hand, it might make more sense to create a separate model (or use simple strings) for the names to be saved in the config.Also I kinda suck at front-end so if this ends up going through I'm gonna ask you to smooth the rough edges 🙏