feat: upgrade from latest vscode-eslint #118

fannheyward · 2021-10-15T00:30:55Z

closes #117

vscode-eslint 2.0 added settings migration, this is not ported
ConfirmExecution has been removed
rulesCustomizations supports
eslintServer.ts supports ESLint 8+, use the new ESLint https://eslint.org/docs/user-guide/migrating-to-7.0.0#deprecate-cliengine

1. ConfirmExecution has been removed 2. vscode-eslint 2.0+ added a settings migration, not ported to coc-eslint https://github.com/microsoft/vscode-eslint#settings-migration

tstirrat15 · 2021-10-18T20:53:20Z

Thank you for putting in the work on this! Is there anything I/we can do to help this get through?

fannheyward · 2021-10-19T01:41:10Z

@tstirrat15 you can try this work or not with your project.

:CocUninstall coc-eslint to uninstall the old release
clone the repo and checkout this PR
yarn install && yarn build
set runtimepath^=~/src/coc-eslint in your vimrc

That's all, you're now using this PR coc-eslint.

tstirrat15 · 2021-10-19T13:42:24Z

Will do. Thanks!

tstirrat15 · 2021-10-19T13:47:40Z

To clarify: I want to uninstall coc-eslint, right?

fannheyward · 2021-10-19T13:51:53Z

Yes, uninstall it and set local coc-eslint.

tstirrat15 · 2021-10-19T13:52:18Z

I got it installed, and it's registered as a service under :CocList services. It doesn't show up under :CocList extensions, though TSServer does. When I run :CocCommand eslint.autoFix, I get an error:

[coc.nvim] Failed to apply ESLint fixes to the document. Please consider opening an issue with steps to reproduce

Is there anything obvious that I should check?

fannheyward · 2021-10-19T13:54:19Z

It doesn't show up under :CocList extensions

How do you set it?

tstirrat15 · 2021-10-19T14:03:11Z

Ah, wait, sorry, I got that backwards. coc-eslint shows up in the extensions list and is activated, but does not show up under the services list. Here's what it looks like in the extensions list:

  * coc-tsserver 1.8.6 ~/.config/coc/extensions/node_modules/coc-tsserver                                                                                                                                  
  * coc-eslint [RTP] 1.4.5 ~/clones/coc-eslint
  + coc-solargraph 1.2.2 ~/.config/coc/extensions/node_modules/coc-solargraph

fannheyward · 2021-10-19T14:20:37Z

Sorry I'm away from work by now and will check the autofix issue later. Thank you for your tests.

tstirrat15 · 2021-10-19T14:22:01Z

Sure, no worries. The autofix issue is just a part of it - it's also not highlighting anything. There's nothing in :CocInfo that would indicate an error, though. Lemme know if there's other diagnostics I can provide.

fannheyward · 2021-10-20T11:23:09Z

@tstirrat15 there's no :CocCommand eslint.autoFix command. Do you mean :CocCommand eslint.executeAutofix? In my tests, CocCommand eslint.executeAutofix works as expected.

tstirrat15 · 2021-10-20T13:50:38Z

Let me check again. I think I just fatfingered the command when I was typing it out in my last comment.

tstirrat15 · 2021-10-20T14:42:19Z

Aaaand now it's working perfectly. I think it might have been something screwy in my node_modules.

tstirrat15 · 2021-10-20T15:02:03Z

For additional context, the file that I was linting had a react exhaustive deps error, but that plugin hasn't been updated yet. I was able to diagnose it by running yarn run eslint <file> in a separate terminal. Is there a place to find that sort of diagnostic information within nvim/coc?

fannheyward · 2021-10-21T01:30:03Z

@tstirrat15 try to enable the trace logs by "eslint.trace.server": "verbose" in your coc-settings.json, and checkout :CocCommand workspace.showOutput eslint.

IDK you can find the diagnostics or not in the trace logs, please give it a try.

skilbjo · 2021-10-31T01:07:30Z

@tstirrat15 you can try this work or not with your project.

:CocUninstall coc-tsserver to uninstall the old release

clone the repo and checkout this PR

yarn install && yarn build

set runtimepath^=~/src/coc-eslint in your vimrc

That's all, you're now using this PR coc-eslint.

One note to these instructions, you need to check out the correct branch (feat/eslint-8). Here are my edits:

- :CocUninstall coc-eslint
- git clone fannheyward/coc-eslint ~/dev/coc-eslint
- cd ~/dev/coc-eslint && git checkout feat/eslint-8
- yarn install && yarn build
- (in `~/.vimrc`) set runtimepath^=~/dev/coc-eslint

Working great for me so far @fannheyward . Any word when you plan to merge?

tstirrat15 · 2021-11-01T15:37:01Z

Seconding - everything worked well. Thank you!

jougene · 2021-11-10T15:16:30Z

When it can be merged?

Seb-C · 2021-11-19T01:06:57Z

@chemzqm Are you still maintaining this project?
I think we are a lot to wait for this major issue to be fixed, so it would be useful to know if we can expect it to be merged any soon or if someone should take the lead and fork it.
Thank you 🙇

fannheyward · 2021-11-19T01:19:49Z

Hello guys, I just published https://www.npmjs.com/package/coc-eslint8, with this PR ESLint 8 support. You can :CocUninstall coc-eslint and :CocInstall coc-eslint8.

Note that: after chemzqm came back and merge this PR, the you should use back coc-eslint.

Seb-C · 2021-11-19T04:01:32Z

@fannheyward Thank you so much! It works perfectly here ❤️ .

EvgeniyRRU · 2021-11-19T05:37:24Z

@fannheyward, is https://www.npmjs.com/package/coc-eslint8 supports eslint7?

fannheyward · 2021-11-19T05:38:36Z

@EvgeniyRRU yes

dannobytes · 2021-11-30T01:45:10Z

Thank you so much for fixing this @fannheyward !! 👏🏼

adelin-b · 2021-12-02T21:59:52Z

Hello guys, I just published https://www.npmjs.com/package/coc-eslint8, with this PR ESLint 8 support. You can :CocUninstall coc-eslint and :CocInstall coc-eslint8.

Note that: after chemzqm came back and merge this PR, the you should use back coc-eslint.

Thank you a lot, could you add the reasons in the Readme of the package ? I was randomly looking through coc marketplace and thought it was a scam package as it state v2.0.0 while the original package is v1.4.5 I think. Almost reported it

neoclide/coc-eslint#118 (comment)

The previous version of eslint might not work properly neoclide/coc-eslint#118

yaegassy · 2021-12-23T01:45:28Z

@chemzqm ping

fannheyward · 2021-12-23T07:26:23Z

To anyone who use coc-eslint8, you should use coc-eslint 1.5.0 now.

nuc · 2022-03-13T10:47:01Z

@fannheyward Next time you are in Berlin, the beers are on me 🍻

feat: upgrade eslintServer from vscode-eslint

1c640f9

fannheyward changed the title ~~feat: upgrade eslintServer from vscode-eslint~~ [WIP] feat: upgrade eslintServer from vscode-eslint Oct 15, 2021

fannheyward marked this pull request as draft October 15, 2021 06:56

feat: update client side

bd48472

1. ConfirmExecution has been removed 2. vscode-eslint 2.0+ added a settings migration, not ported to coc-eslint https://github.com/microsoft/vscode-eslint#settings-migration

fannheyward changed the title ~~[WIP] feat: upgrade eslintServer from vscode-eslint~~ [WIP] feat: upgrade from latest vscode-eslint Oct 15, 2021

fannheyward marked this pull request as ready for review October 15, 2021 10:00

fannheyward changed the title ~~[WIP] feat: upgrade from latest vscode-eslint~~ feat: upgrade from latest vscode-eslint Oct 15, 2021

chore: remove logs

42cde2d

fix: rollback to eslint.execArgv

7ff1d11

pjg mentioned this pull request Nov 25, 2021

It doesn't work with eslint v8 prettier/prettier-eslint#656

Closed

duykhoa mentioned this pull request Nov 29, 2021

Doesn't work with esLint 8.x #117

Closed

UltiRequiem added a commit to UltiRequiem/UltiVim that referenced this pull request Dec 13, 2021

🎨 Eslint8

9037011

neoclide/coc-eslint#118 (comment)

TianboQiu305 pushed a commit to Tianbo-Qiu/Vim that referenced this pull request Dec 16, 2021

Upgrade to use eslint8

b88ed74

The previous version of eslint might not work properly neoclide/coc-eslint#118

TianboQiu305 mentioned this pull request Dec 16, 2021

Upgrade to use eslint8 Tianbo-Qiu/Vim#8

Merged

chemzqm approved these changes Dec 23, 2021

View reviewed changes

chemzqm merged commit deff067 into neoclide:master Dec 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade from latest vscode-eslint #118

feat: upgrade from latest vscode-eslint #118

fannheyward commented Oct 15, 2021 •

edited

Loading

tstirrat15 commented Oct 18, 2021

fannheyward commented Oct 19, 2021 •

edited

Loading

tstirrat15 commented Oct 19, 2021

tstirrat15 commented Oct 19, 2021

fannheyward commented Oct 19, 2021

tstirrat15 commented Oct 19, 2021

fannheyward commented Oct 19, 2021

tstirrat15 commented Oct 19, 2021

fannheyward commented Oct 19, 2021

tstirrat15 commented Oct 19, 2021

fannheyward commented Oct 20, 2021

tstirrat15 commented Oct 20, 2021

tstirrat15 commented Oct 20, 2021

tstirrat15 commented Oct 20, 2021

fannheyward commented Oct 21, 2021

skilbjo commented Oct 31, 2021

tstirrat15 commented Nov 1, 2021

jougene commented Nov 10, 2021

Seb-C commented Nov 19, 2021

fannheyward commented Nov 19, 2021

Seb-C commented Nov 19, 2021 •

edited

Loading

EvgeniyRRU commented Nov 19, 2021

fannheyward commented Nov 19, 2021

dannobytes commented Nov 30, 2021

adelin-b commented Dec 2, 2021

yaegassy commented Dec 23, 2021

fannheyward commented Dec 23, 2021

nuc commented Mar 13, 2022

feat: upgrade from latest vscode-eslint #118

feat: upgrade from latest vscode-eslint #118

Conversation

fannheyward commented Oct 15, 2021 • edited Loading

tstirrat15 commented Oct 18, 2021

fannheyward commented Oct 19, 2021 • edited Loading

tstirrat15 commented Oct 19, 2021

tstirrat15 commented Oct 19, 2021

fannheyward commented Oct 19, 2021

tstirrat15 commented Oct 19, 2021

fannheyward commented Oct 19, 2021

tstirrat15 commented Oct 19, 2021

fannheyward commented Oct 19, 2021

tstirrat15 commented Oct 19, 2021

fannheyward commented Oct 20, 2021

tstirrat15 commented Oct 20, 2021

tstirrat15 commented Oct 20, 2021

tstirrat15 commented Oct 20, 2021

fannheyward commented Oct 21, 2021

skilbjo commented Oct 31, 2021

tstirrat15 commented Nov 1, 2021

jougene commented Nov 10, 2021

Seb-C commented Nov 19, 2021

fannheyward commented Nov 19, 2021

Seb-C commented Nov 19, 2021 • edited Loading

EvgeniyRRU commented Nov 19, 2021

fannheyward commented Nov 19, 2021

dannobytes commented Nov 30, 2021

adelin-b commented Dec 2, 2021

yaegassy commented Dec 23, 2021

fannheyward commented Dec 23, 2021

nuc commented Mar 13, 2022

fannheyward commented Oct 15, 2021 •

edited

Loading

fannheyward commented Oct 19, 2021 •

edited

Loading

Seb-C commented Nov 19, 2021 •

edited

Loading