Skip to content

Commit

Permalink
Add ESLint 6 support
Browse files Browse the repository at this point in the history
  • Loading branch information
iansu committed Oct 16, 2019
1 parent 8211ee3 commit 414e9b7
Show file tree
Hide file tree
Showing 7 changed files with 621 additions and 285 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# Changelog

## 0.4.0 (October 16, 2019)

- Add support for ESLint 6
- Update `typescript-eslint` to `2.4.0`
- Update all dependencies

## 0.3.3 (August 30, 2019)

- Revert `@typescript-eslint/promise-function-async` rule due to performance issues
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Add `.eslintrc` to project root
}
```

*Use `eslint-config-neo/config-frontend` for frontend projects*
_Use `eslint-config-neo/config-frontend` for frontend projects_

### Make Prettier Config File

Expand Down
3 changes: 1 addition & 2 deletions config-backend.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
module.exports = {
extends: ['eslint-config-neo'],
extends: ['./index.js'],
env: {
node: true,
jest: true,
mongo: true
},
rules: {
Expand Down
5 changes: 2 additions & 3 deletions config-frontend.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
module.exports = {
extends: ['eslint-config-neo', 'plugin:node/recommended', 'plugin:react/recommended'],
extends: ['./index.js', 'plugin:node/recommended', 'plugin:react/recommended'],
plugins: ['node', 'react', 'react-hooks'],
env: {
browser: true,
jest: true
browser: true
},
settings: {
react: {
Expand Down
4 changes: 1 addition & 3 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ module.exports = {
'@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_+' }],
'@typescript-eslint/explicit-function-return-type': 'error',

// Commentingi this out until we are on 2.0.0
// This makes the linter 10x slower on 1.x
//
// disabled for performance reasons for now, rules that require type information are very slow
// '@typescript-eslint/promise-function-async': [
// "error",
// {
Expand Down
30 changes: 15 additions & 15 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-config-neo",
"version": "0.3.3",
"version": "0.4.0",
"description": "Official Neo Financial ESLint configuration",
"main": "index.js",
"author": "Neo Financial Engineering <engineering@neofinancial.com>",
Expand All @@ -14,23 +14,23 @@
"*.js"
],
"peerDependencies": {
"eslint": "^5.16.0",
"prettier": "^1.16.4"
"eslint": "^5.0.0 || ^6.0.0",
"prettier": "^1.18.2"
},
"dependencies": {
"@typescript-eslint/eslint-plugin": "^1.6.0",
"@typescript-eslint/parser": "^1.6.0",
"eslint-config-prettier": "^4.1.0",
"eslint-plugin-import": "^2.17.3",
"eslint-plugin-jest": "^22.7.0",
"eslint-plugin-node": "^8.0.1",
"eslint-plugin-promise": "^4.1.1",
"eslint-plugin-react": "^7.12.4",
"eslint-plugin-react-hooks": "^1.6.0",
"eslint-plugin-unicorn": "^8.0.1"
"@typescript-eslint/eslint-plugin": "^2.4.0",
"@typescript-eslint/parser": "^2.4.0",
"eslint-config-prettier": "^6.4.0",
"eslint-plugin-import": "^2.18.2",
"eslint-plugin-jest": "^22.19.0",
"eslint-plugin-node": "^10.0.0",
"eslint-plugin-promise": "^4.2.1",
"eslint-plugin-react": "^7.16.0",
"eslint-plugin-react-hooks": "^2.1.2",
"eslint-plugin-unicorn": "^12.1.0"
},
"devDependencies": {
"eslint": "^5.16.0",
"prettier": "^1.16.4"
"eslint": "^6.5.1",
"prettier": "^1.18.2"
}
}
Loading

0 comments on commit 414e9b7

Please sign in to comment.