Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.20.x] Render local player when the renderViewEntity is not the local player #858

Merged
merged 2 commits into from
Apr 30, 2024
Merged

[1.20.x] Render local player when the renderViewEntity is not the local player #858

merged 2 commits into from
Apr 30, 2024

Conversation

CreativeMD
Copy link
Contributor

Hey there,
I noticed that NeoForge is missing the fix for not rendering the local player when a custom view entity has been set. The original fix can be found here: MinecraftForge/MinecraftForge#7216

This pr readds the fix.

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@Shadows-of-Fire Shadows-of-Fire added bug A bug or error rendering Related to rendering regression Worked previously but doesn't anymore 1.20.5 Targeted at Minecraft 1.20.5 labels Apr 26, 2024
embeddedt
embeddedt approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we lost the patch in the 20.2 update (probably from moving to Vineflower), seems fine to re-add.

@embeddedt embeddedt merged commit 339d880 into neoforged:1.20.x Apr 30, 2024
4 checks passed
@CreativeMD CreativeMD deleted the 1.20.x_render_fix branch April 30, 2024 07:10
ApexModder pushed a commit to ApexModder/NeoForge that referenced this pull request May 3, 2024
@CreativeMD @ApexModder
Render local player when the renderViewEntity is not the local player (…
ccdbe1b 
…neoforged#858)
This was referenced Jun 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadows-of-Fire Shadows-of-Fire Shadows-of-Fire left review comments

@embeddedt embeddedt embeddedt approved these changes

Assignees
No one assigned
Labels
1.20.5 Targeted at Minecraft 1.20.5 bug A bug or error regression Worked previously but doesn't anymore rendering Related to rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CreativeMD @CLAassistant @Shadows-of-Fire @embeddedt