Add Location as a field of YMDFlag #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevM
approved these changes
Aug 14, 2023
Signed-off-by: Kevin Miller <kevin@neomantra.net>
Signed-off-by: Kevin Miller <kevin@neomantra.net>
Signed-off-by: Kevin Miller <kevin@neomantra.net>
…e happens Signed-off-by: Kevin Miller <kevin@neomantra.net>
Signed-off-by: Kevin Miller <kevin@neomantra.net>
Signed-off-by: Kevin Miller <kevin@neomantra.net>
Signed-off-by: Kevin Miller <kevin@neomantra.net>
Signed-off-by: Kevin Miller <kevin@neomantra.net>
Signed-off-by: Kevin Miller <kevin@neomantra.net>
Signed-off-by: Kevin Miller <kevin@neomantra.net>
KevM
pushed a commit
that referenced
this pull request
Aug 21, 2023
* Add Location as a field of YMDFlag, refactor with public helpers Signed-off-by: Kevin Miller <kevin@neomantra.net> * Add examples and Taskfile Signed-off-by: Kevin Miller <kevin@neomantra.net> * More interface refinement Signed-off-by: Kevin Miller <kevin@neomantra.net> * Remove Location field and simplify interface, limiting where auto-date happens Signed-off-by: Kevin Miller <kevin@neomantra.net> * add yyyymmdd validation tests Signed-off-by: Kevin Miller <kevin@neomantra.net> * moar tests Signed-off-by: Kevin Miller <kevin@neomantra.net> * Trying things out Signed-off-by: Kevin Miller <kevin@neomantra.net> * Move to newer test action Signed-off-by: Kevin Miller <kevin@neomantra.net> * add clarifying comment Signed-off-by: Kevin Miller <kevin@neomantra.net> * fix linter issue Signed-off-by: Kevin Miller <kevin@neomantra.net> * More action cleanup * task update also updates tests --------- Signed-off-by: Kevin Miller <kevin@neomantra.net> Co-authored-by: Kevin Miller <kevin@neomantra.net> Signed-off-by: Kevin Miller <kevin@neomantra.net>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
time.Timecarries time data and atime.Location,ymdflag.YMDFlagonly had theyyyymmddtime data and no location. This made the interface confusing with respect to location. This commit adds atime.Locationfield and methods for dealing with it. Conversions to and fromtime.Timerespect theLocation.This is breaking interface change -- but we have no version tags on this package yet.