Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Spelling checker has been modified" #75

Merged
merged 13 commits into from
Mar 13, 2023

Conversation

neomatrix369
Copy link
Owner

Reverts #71

Reverting spell check to previous spell check as the new one introduced does not catch the previously incorrectly spelt words. Need to review further before re-appling this check.

@neomatrix369 neomatrix369 added bug Something isn't working high-level feature(s) labels Mar 12, 2023
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 12, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.12%.

Quality metrics Before After Change
Complexity 2.25 ⭐ 1.94 ⭐ -0.31 👍
Method Length 43.77 ⭐ 41.15 ⭐ -2.62 👍
Working memory 5.31 ⭐ 5.17 ⭐ -0.14 👍
Quality 85.51% 86.63% 1.12% 👍
Other metrics Before After Change
Lines 337 320 -17
Changed files Quality Before Quality After Quality Change
setup.py 67.46% 🙂 67.46% 🙂 0.00%
nlp_profiler/high_level_features/ease_of_reading_check.py 85.18% ⭐ 85.73% ⭐ 0.55% 👍
nlp_profiler/high_level_features/grammar_quality_check.py 90.16% ⭐ 90.11% ⭐ -0.05% 👎
nlp_profiler/high_level_features/spelling_quality_check.py 84.28% ⭐ 87.36% ⭐ 3.08% 👍
tests/granular/test_nounphrase.py % % %
tests/granular/test_syllables.py 90.40% ⭐ 90.40% ⭐ 0.00%
tests/high_level/test_ease_of_reading_check.py 87.93% ⭐ 87.93% ⭐ 0.00%
tests/high_level/test_grammar_check.py 87.91% ⭐ 87.91% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@neomatrix369 neomatrix369 force-pushed the revert-71-spelling_check branch from 0e1bc54 to 7dff6c2 Compare March 12, 2023 22:31
@neomatrix369 neomatrix369 self-assigned this Mar 12, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dde3172) 100.00% compared to head (2cddf51) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #75   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          498       498           
  Branches        74        74           
=========================================
  Hits           498       498           
Impacted Files Coverage Δ
...filer/high_level_features/grammar_quality_check.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@neomatrix369 neomatrix369 force-pushed the revert-71-spelling_check branch from 6219e04 to 677707d Compare March 13, 2023 02:41
@neomatrix369
Copy link
Owner Author

Merging for now, will review windows report writing error caused due to unicode encoding via a separate issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-level feature(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant