Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples.component.multiWindowHelix.ViewportController: dynamic popup heights #5991

Closed
tobiu opened this issue Sep 30, 2024 · 2 comments
Closed

examples.component.multiWindowHelix.ViewportController: dynamic popup heights #5991

tobiu opened this issue Sep 30, 2024 · 2 comments
Assignees
@tobiu
Labels
enhancement New feature or request

Comments

@tobiu
Copy link
Collaborator

tobiu commented Sep 30, 2024

we do need a different positioning for:

  • running the main window as a "standalone" app
  • running the main window inside a code.LivePreview

Screenshot 2024-09-30 at 17 44 40

Screenshot 2024-09-30 at 17 45 08
@tobiu tobiu added the enhancement New feature or request label Sep 30, 2024
@tobiu tobiu self-assigned this Sep 30, 2024
tobiu added a commit that referenced this issue Sep 30, 2024
@tobiu
examples.component.multiWindowHelix.ViewportController: dynamic popup…
e6ba158 
… heights #5991
@tobiu
Copy link
Collaborator Author

tobiu commented Sep 30, 2024

just to be clear: this needs to work too:

Screenshot 2024-09-30 at 17 28 35

@tobiu tobiu closed this as completed Sep 30, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Portal & LearningSection Sep 30, 2024
@tobiu
Copy link
Collaborator Author

tobiu commented Sep 30, 2024

  • let us reopen this ticket to add a smarter check which works inside any code.LivePreview (not limited to the Portal App)
  • let us also add the check into examples.component.multiWindowCoronaGallery.ViewportController, since we might add an inline demo into the Portal App later

@tobiu tobiu reopened this Sep 30, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in Portal & LearningSection Sep 30, 2024
tobiu added a commit that referenced this issue Sep 30, 2024
@tobiu
#5991 examples.component.multiWindowHelix.ViewportController: smarter…
054bd8d 
… check for parent LivePreviews
@tobiu tobiu closed this as completed Sep 30, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Portal & LearningSection Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiu tobiu

Labels
enhancement New feature or request
Projects
Portal & LearningSection
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tobiu