Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port win_delay_load_hook #588

Merged
merged 14 commits into from
Sep 18, 2020
Merged

Port win_delay_load_hook #588

merged 14 commits into from
Sep 18, 2020

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Aug 13, 2020 •
edited
Loading

This builds on #583 to support the renamed executable use case mentioned in that OP.

This PR ports the win_delay_load_hook from node-gyp to Rust. See #584 (comment) for background and reasoning.

Todo:

  • Support "electron.exe". I think we were just going to hardcode a list of acceptable names, since there are not many, and this code is likely to be temporary anyways.

@goto-bus-stop goto-bus-stop mentioned this pull request Sep 14, 2020
Merged
3 tasks
@kjvalencik kjvalencik merged commit a5f0457 into neon-bindings:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjvalencik kjvalencik kjvalencik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goto-bus-stop @kjvalencik