Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neonvm-runner: arm support #1119

Merged
merged 7 commits into from
Dec 17, 2024
Merged

neonvm-runner: arm support #1119

merged 7 commits into from
Dec 17, 2024

Conversation

mikhail-sakhnov
Copy link
Contributor

@mikhail-sakhnov mikhail-sakhnov commented Oct 21, 2024 •
edited
Loading

Modify qemu arguments to run VM on arm machine

#1080

@mikhail-sakhnov mikhail-sakhnov changed the title Misha/runner arm support vm-runner: arm support Oct 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

No changes to the coverage.

HTML Report

Click to open

@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/runner-arm-support branch from e5a9046 to 111e19c Compare October 21, 2024 13:33
sharnoff
sharnoff reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, AFAICT

neonvm-runner/cmd/main.go Outdated Show resolved Hide resolved
neonvm-runner/cmd/main.go Show resolved Hide resolved
tests/e2e/autoscaling.cpu-sys-fs-state-scaling/00-create-vm.yaml Show resolved Hide resolved
@mikhail-sakhnov mikhail-sakhnov mentioned this pull request Oct 22, 2024
Merged
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/runner-arm-support branch from 111e19c to 853186d Compare October 22, 2024 10:08
@mikhail-sakhnov mikhail-sakhnov mentioned this pull request Oct 22, 2024
Open
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/runner-arm-support branch 2 times, most recently from ecc2853 to 8a7a20c Compare October 24, 2024 13:57
@mikhail-sakhnov mikhail-sakhnov marked this pull request as ready for review October 28, 2024 12:12
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch from ed64800 to 629281d Compare October 31, 2024 00:52
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/runner-arm-support branch 2 times, most recently from 3d7f393 to 59ccc89 Compare October 31, 2024 02:14
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch from 629281d to 6fb99e4 Compare October 31, 2024 02:14
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/runner-arm-support branch 4 times, most recently from 905c042 to 281aa47 Compare November 26, 2024 11:44
Omrigan
Omrigan reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@Omrigan Omrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Perhaps, PR should be named something like "enable e2e tests on arm", with multiple commits, 1 per each component?

pkg/neonvm/controllers/vm_controller.go Show resolved Hide resolved
pkg/neonvm/controllers/vm_controller.go Show resolved Hide resolved
neonvm-vxlan-controller/Dockerfile Outdated Show resolved Hide resolved
@mikhail-sakhnov
Copy link
Contributor Author

Perhaps, PR should be named something like "enable e2e tests on arm", with multiple commits, 1 per each component?

@Omrigan I am hesitant towards that title, because the PR does what it says - enables vm-runner to run ARM vms. There is one test modified to reflect that change. Plus there actually separate issue and PR about e2e tests on ARM.

@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/runner-arm-support branch from 281aa47 to c68ad69 Compare December 2, 2024 10:56
@Omrigan Omrigan changed the title vm-runner: arm support neonvm-runner: arm support Dec 2, 2024
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/runner-arm-support branch from c68ad69 to a67498c Compare December 4, 2024 12:42
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch 3 times, most recently from c82d27a to 1abd54a Compare December 4, 2024 13:49
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/runner-arm-support branch from a67498c to 52ff187 Compare December 4, 2024 13:50
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch 2 times, most recently from c63ada8 to f4dce7b Compare December 4, 2024 14:06
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/runner-arm-support branch 3 times, most recently from 487d6a4 to a86445c Compare December 4, 2024 14:15
@mikhail-sakhnov
Copy link
Contributor Author

@Omrigan @sharnoff what is the current state of review?

sharnoff
sharnoff reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@sharnoff sharnoff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. I may have some follow-up questions pending the outcome of the runtime.GOARCH one, but should be nothing major -- broadly looks good

neonvm-runner/Dockerfile Show resolved Hide resolved
neonvm-runner/cmd/main.go Outdated Show resolved Hide resolved
neonvm-runner/cmd/main.go Show resolved Hide resolved
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch from a2d3587 to 5bee7bc Compare December 10, 2024 08:01
Base automatically changed from misha/builder-arm-support to main December 10, 2024 09:26
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/runner-arm-support branch 2 times, most recently from e03dc76 to 9bf6c24 Compare December 10, 2024 11:04
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/runner-arm-support branch 4 times, most recently from 2e712d7 to f9e7e75 Compare December 13, 2024 12:00
mikhail-sakhnov and others added 7 commits December 17, 2024 09:13
@mikhail-sakhnov
neonvm-runner: modify qemu arguments to run on arm64
f426421
@mikhail-sakhnov
e2e: disable extraNetwork and set virtio memory provider for cpu-sys-…
8dbcba7 
…fs-state-scaling
@mikhail-sakhnov
neonvm-runner: move comments for config fields
c86c18c 
Signed-off-by: Misha Sakhnov <misha@neon.tech>
@mikhail-sakhnov
neonvm-runner: add linaro firmware for arm
793c243 
Signed-off-by: Mikhail Sakhnov <mikhail@skhnv.me>
@mikhail-sakhnov
neonvm-runner: use virtio-serial for stdio on arm
d73c24b 
Use virtio-serial for kernel and init messages on arm
since machine type virt has only one serial port by default

Signed-off-by: Mikhail Sakhnov <mikhail@skhnv.me>
@mikhail-sakhnov
neonvm-runner: add code comments
c97801a 
Signed-off-by: Mikhail Sakhnov <mikhail@skhnv.me>
@mikhail-sakhnov
neonvm-runner: explicit panic on unsupported arch
acd5cf6 
Replace if-else statements with switch statements
with default panic case while handling cfg.architecture

Signed-off-by: Mikhail Sakhnov <mikhail@skhnv.me>
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/runner-arm-support branch from f9e7e75 to acd5cf6 Compare December 17, 2024 08:13
@mikhail-sakhnov mikhail-sakhnov merged commit 17a07a9 into main Dec 17, 2024
22 checks passed
@mikhail-sakhnov mikhail-sakhnov deleted the misha/runner-arm-support branch December 17, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdteam cicdteam cicdteam left review comments

@sharnoff sharnoff sharnoff approved these changes

@Omrigan Omrigan Omrigan approved these changes

Assignees

@Omrigan Omrigan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikhail-sakhnov @Omrigan @cicdteam @sharnoff