Skip to content

Commit

Permalink
Bump neon.logical_replication_max_snap_files default to 10000 (#9896)
Browse files Browse the repository at this point in the history 
This bump comes from a recommendation from Chi.

Signed-off-by: Tristan Partin <tristan@neon.tech>
  • Loading branch information
@tristan957
tristan957 authored Nov 26, 2024
1 parent 13feda0 commit 2b788cb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pgxn/neon/logical_replication_monitor.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

#define LS_MONITOR_CHECK_INTERVAL 10000 /* ms */

static int logical_replication_max_snap_files = 300;
static int logical_replication_max_snap_files = 10000;

/*
* According to Chi (shyzh), the pageserver _should_ be good with 10 MB worth of
Expand Down Expand Up @@ -184,7 +184,7 @@ InitLogicalReplicationMonitor(void)
"Maximum allowed logical replication .snap files. When exceeded, slots are dropped until the limit is met. -1 disables the limit.",
NULL,
&logical_replication_max_snap_files,
300, -1, INT_MAX,
10000, -1, INT_MAX,
PGC_SIGHUP,
0,
NULL, NULL, NULL);
Expand Down

1 comment on commit 2b788cb

@github-actions
Copy link

@github-actions github-actions bot commented on 2b788cb Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7056 tests run: 6723 passed, 0 failed, 333 skipped (full report)

Flaky tests (6)

Postgres 17

Postgres 16

  • test_sharded_ingest[github-actions-selfhosted-vanilla-1]: release-x86-64

Postgres 14

Code coverage* (full report)

  • functions: 30.9% (7976 of 25851 functions)
  • lines: 48.6% (63304 of 130182 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
2b788cb at 2024-11-26T20:27:29.953Z :recycle:

Please sign in to comment.