Skip to content

Commit

Permalink
allow storage_controller error during pagebench (#8109)
Browse files Browse the repository at this point in the history
## Problem

`test_pageserver_max_throughput_getpage_at_latest_lsn` is a pagebench
testcase which creates several tenants/timelines to verify pageserver
performance.


The test swaps environments around in the tenant duplication stage, so
the storage controller uses two separate db instances (one in the
duplication stage and another one in the benchmarking stage).
In the benchmarking stage, the storage controller starts without any
knowledge of nodes, but with knowledge of tenants (via
attachments.json). When we re-attach and attempt to update the scheduler
stats, the scheduler rightfully complains
about the node not being known. The setup should preserve the storage
controller across the two envs, but i think it's fine to just allow list
the error in this case.

## Summary of changes

add the error message 

`2024-06-19T09:38:27.866085Z ERROR Scheduler missing node 1``

to the list of allowed errors for storage_controller
  • Loading branch information
Bodobolero authored Jun 19, 2024
1 parent b998b70 commit 56da624
Showing 1 changed file with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -209,3 +209,11 @@ def run_benchmark_max_throughput_latest_lsn(
unit="ms",
report=MetricReport.LOWER_IS_BETTER,
)

env.storage_controller.allowed_errors.append(
# The test setup swaps NeonEnv instances, hence different
# pg instances are used for the storage controller db. This means
# the storage controller doesn't know about the nodes mentioned
# in attachments.json at start-up.
".* Scheduler missing node 1",
)

1 comment on commit 56da624

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3316 tests run: 3189 passed, 1 failed, 126 skipped (full report)


Failures on Postgres 14

  • test_tenant_delete_smoke: debug
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_tenant_delete_smoke[debug-pg14]"

Test coverage report is not available

The comment gets automatically updated with the latest test results
56da624 at 2024-06-19T15:31:31.700Z :recycle:

Please sign in to comment.