pageserver: don't ingest checkpoint page on shards >0

neondatabase · Nov 20, 2024 · 636e702 · 636e702
1 parent e67d9b4
commit 636e702
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pageserver/src/walingest.rs b/pageserver/src/walingest.rs
@@ -162,7 +162,7 @@ impl WalIngest {
             assert!(!modification.has_dirty_data());
         }
 
-        assert!(!self.checkpoint_modified);
+        assert!(!self.checkpoint_modified || !self.shard.is_shard_zero());
         if interpreted.xid != pg_constants::INVALID_TRANSACTION_ID
             && self.checkpoint.update_next_xid(interpreted.xid)
         {
@@ -277,8 +277,8 @@ impl WalIngest {
             .ingest_batch(interpreted.batch, &self.shard, ctx)
             .await?;
 
-        // If checkpoint data was updated, store the new version in the repository
-        if self.checkpoint_modified {
+        // If checkpoint data was updated, store the new version in the repository (on shard zero only)
+        if self.checkpoint_modified && self.shard.is_shard_zero() {
             let new_checkpoint_bytes = self.checkpoint.encode()?;
 
             modification.put_checkpoint(new_checkpoint_bytes)?;