Skip to content

Commit

Permalink
handle, align, remove fixmes
Browse files Browse the repository at this point in the history
  • Loading branch information
koivunej committed Oct 26, 2023
1 parent fa51cc9 commit 6778c54
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
3 changes: 1 addition & 2 deletions pageserver/src/tenant/storage_layer/layer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1082,8 +1082,7 @@ pub(crate) struct DownloadedLayer {
impl std::fmt::Debug for DownloadedLayer {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
f.debug_struct("DownloadedLayer")
// FIXME: this is not useful, always "Weak"
.field("owner", &self.owner)
// owner omitted because it is always "Weak"
.field("kind", &self.kind)
.finish()
}
Expand Down
4 changes: 1 addition & 3 deletions pageserver/src/tenant/timeline.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2629,7 +2629,7 @@ impl Timeline {
// 4. fsync the parent directory.
// Note that (1),(2),(3) today happen inside write_to_disk().
//
// FIXME: writer has already fsynced contents, we only need to fsync the rename
// FIXME: the writer already fsyncs all data, only rename needs to be fsynced here
par_fsync::par_fsync(&[new_delta_path]).context("fsync of delta layer")?;
par_fsync::par_fsync(&[self_clone
.conf
Expand Down Expand Up @@ -3498,8 +3498,6 @@ impl Timeline {
// Before deleting any layers, we need to wait for their upload ops to finish.
// See remote_timeline_client module level comment on consistency.
// Do it here because we don't want to hold self.layers.write() while waiting.
//
// FIXME: this will become extra with #4938
if let Some(remote_client) = &self.remote_client {
debug!("waiting for upload ops to complete");
remote_client
Expand Down

0 comments on commit 6778c54

Please sign in to comment.