Skip to content

Commit

Permalink
vm-monitor: Remove dependency on workspace_hack (#5752)
Browse files Browse the repository at this point in the history
neondatabase/autoscaling builds libs/vm-monitor during CI because it's a
necessary component of autoscaling.

workspace_hack includes a lot of crates that are not necessary for
vm-monitor, which artificially inflates the build time on the
autoscaling side, so hopefully removing the dependency should speed
things up.

Co-authored-by: Joonas Koivunen <joonas@neon.tech>
  • Loading branch information
sharnoff and koivunej authored Nov 7, 2023
1 parent 11d9d80 commit acef742
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .config/hakari.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,11 @@ platforms = [
# "x86_64-pc-windows-msvc",
]

[final-excludes]
# vm_monitor benefits from the same Cargo.lock as the rest of our artifacts, but
# it is built primarly in separate repo neondatabase/autoscaling and thus is excluded
# from depending on workspace-hack because most of the dependencies are not used.
workspace-members = ["vm_monitor"]

# Write out exact versions rather than a semver range. (Defaults to false.)
# exact-versions = true
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions libs/vm_monitor/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,12 @@ inotify.workspace = true
serde.workspace = true
serde_json.workspace = true
sysinfo.workspace = true
tokio.workspace = true
tokio = { workspace = true, features = ["rt-multi-thread"] }
tokio-postgres.workspace = true
tokio-stream.workspace = true
tokio-util.workspace = true
tracing.workspace = true
tracing-subscriber.workspace = true
workspace_hack = { version = "0.1", path = "../../workspace_hack" }

[target.'cfg(target_os = "linux")'.dependencies]
cgroups-rs = "0.3.3"

1 comment on commit acef742

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2438 tests run: 2316 passed, 0 failed, 122 skipped (full report)


Flaky tests (3)

Postgres 16

Postgres 14

  • test_pageserver_restarts_under_worload: debug

Code coverage (full report)

  • functions: 54.8% (8901 of 16257 functions)
  • lines: 81.7% (51277 of 62762 lines)

The comment gets automatically updated with the latest test results
acef742 at 2023-11-07T18:28:03.161Z :recycle:

Please sign in to comment.