Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remote_storage/abs: count 404 and 304 for get as ok for metrics (#9912)
## Problem We currently see elevated levels of errors for GetBlob requests. This is because 404 and 304 are counted as errors for metric reporting. ## Summary of Changes Bring the implementation in line with the S3 client and treat 404 and 304 responses as ok for metric purposes. Related: neondatabase/cloud#20666
- Loading branch information
e82f7f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7053 tests run: 6719 passed, 1 failed, 333 skipped (full report)
Failures on Postgres 16
test_sharded_ingest[github-actions-selfhosted-vanilla-1]
: release-x86-64Flaky tests (3)
Postgres 17
test_compute_pageserver_connection_stress
: debug-x86-64test_idle_checkpoints
: debug-x86-64test_wal_restore_http[True]
: release-arm64Code coverage* (full report)
functions
:30.6% (7984 of 26064 functions)
lines
:48.5% (63372 of 130562 lines)
* collected from Rust tests only
e82f7f0 at 2024-11-28T12:06:26.155Z :recycle: