Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
pageserver: remove shard split hard link assertion (#9829)
## Problem We were hitting this assertion in debug mode tests sometimes. This case was being hit when the parent shard has no resident layers. For instance, this is the case on split retry where the previous attempt shut-down the parent and deleted local state for it. If the logical size calculation does not download some layers before we get to the hardlinking, then the assertion is hit. ## Summary of Changes Remove the assertion. It's fine for the ancestor to not have any resident layers at the time of the split. Closes #9412
- Loading branch information
ee26f09
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5626 tests run: 5389 passed, 1 failed, 236 skipped (full report)
Failures on Postgres 16
test_sharded_ingest[github-actions-selfhosted-1]
: release-x86-64Flaky tests (2)
Postgres 16
test_create_churn_during_restart
: release-x86-64Postgres 15
test_pull_timeline[True]
: release-arm64Code coverage* (full report)
functions
:31.4% (7943 of 25312 functions)
lines
:49.3% (63047 of 127877 lines)
* collected from Rust tests only
ee26f09 at 2024-11-20T20:34:53.259Z :recycle: