-
Notifications
You must be signed in to change notification settings - Fork 456
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Compute image: prepare Postgres v14-v16 for Debian 12 (#9954)
## Problem Current compute images for Postgres 14-16 don't build on Debian 12 because of issues with extensions. This PR fixes that, but for the current setup, it is mostly a no-op change. ## Summary of changes - Use `/bin/bash -euo pipefail` as SHELL to fail earlier - Fix `plv8` build: backport a trivial patch for v8 - Fix `postgis` build: depend `sfgal` version on Debian version instead of Postgres version Tested in: #9849
- Loading branch information
Showing
2 changed files
with
53 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
commit 46b38d3e46f9cd6c70d9b189dd6ff4abaa17cf5e | ||
Author: Alexander Bayandin <alexander@neon.tech> | ||
Date: Sat Nov 30 18:29:32 2024 +0000 | ||
|
||
Fix v8 9.7.37 compilation on Debian 12 | ||
|
||
diff --git a/patches/code/84cf3230a9680aac3b73c410c2b758760b6d3066.patch b/patches/code/84cf3230a9680aac3b73c410c2b758760b6d3066.patch | ||
new file mode 100644 | ||
index 0000000..f0a5dc7 | ||
--- /dev/null | ||
+++ b/patches/code/84cf3230a9680aac3b73c410c2b758760b6d3066.patch | ||
@@ -0,0 +1,30 @@ | ||
+From 84cf3230a9680aac3b73c410c2b758760b6d3066 Mon Sep 17 00:00:00 2001 | ||
+From: Michael Lippautz <mlippautz@chromium.org> | ||
+Date: Thu, 27 Jan 2022 14:14:11 +0100 | ||
+Subject: [PATCH] cppgc: Fix include | ||
+ | ||
+Add <utility> to cover for std::exchange. | ||
+ | ||
+Bug: v8:12585 | ||
+Change-Id: Ida65144e93e466be8914527d0e646f348c136bcb | ||
+Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3420309 | ||
+Auto-Submit: Michael Lippautz <mlippautz@chromium.org> | ||
+Reviewed-by: Omer Katz <omerkatz@chromium.org> | ||
+Commit-Queue: Michael Lippautz <mlippautz@chromium.org> | ||
+Cr-Commit-Position: refs/heads/main@{#78820} | ||
+--- | ||
+ src/heap/cppgc/prefinalizer-handler.h | 1 + | ||
+ 1 file changed, 1 insertion(+) | ||
+ | ||
+diff --git a/src/heap/cppgc/prefinalizer-handler.h b/src/heap/cppgc/prefinalizer-handler.h | ||
+index bc17c99b1838..c82c91ff5a45 100644 | ||
+--- a/src/heap/cppgc/prefinalizer-handler.h | ||
++++ b/src/heap/cppgc/prefinalizer-handler.h | ||
+@@ -5,6 +5,7 @@ | ||
+ #ifndef V8_HEAP_CPPGC_PREFINALIZER_HANDLER_H_ | ||
+ #define V8_HEAP_CPPGC_PREFINALIZER_HANDLER_H_ | ||
+ | ||
++#include <utility> | ||
+ #include <vector> | ||
+ | ||
+ #include "include/cppgc/prefinalizer.h" |
fae8e7b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7122 tests run: 6803 passed, 1 failed, 318 skipped (full report)
Failures on Postgres 16
test_sharded_ingest[github-actions-selfhosted-vanilla-1]
: release-x86-64Flaky tests (3)
Postgres 15
test_pull_timeline[True]
: release-arm64Postgres 14
test_pull_timeline[True]
: release-x86-64, release-arm64Code coverage* (full report)
functions
:30.4% (8274 of 27226 functions)
lines
:47.8% (65227 of 136507 lines)
* collected from Rust tests only
fae8e7b at 2024-12-01T14:55:40.771Z :recycle: