Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coarse classification of remaining test failures with =tiered #7749

Closed
1 task done
Tracked by #7554
problame opened this issue May 14, 2024 · 1 comment
Closed
1 task done
Tracked by #7554

coarse classification of remaining test failures with =tiered #7749

problame opened this issue May 14, 2024 · 1 comment
Assignees
@problame

Comments

@problame
Copy link
Contributor

problame commented May 14, 2024 •
edited
Loading

Impl
Preview Give feedback
  1. test_suite: patch, don't replace, the tenant_config field, where appropriate #7771
@problame problame mentioned this issue May 14, 2024
Closed
@problame problame self-assigned this May 14, 2024
This was referenced May 14, 2024
Closed
Merged
problame added a commit that referenced this issue May 15, 2024
@problame
test_suite: patch, don't replace, the tenant_config field, where ap…
f171596 
…propriate

Before this PR, the changed tests would overwrite the entire
`tenant_config` because `pageserver_config_override` is merged
non-recursively into the `ps_cfg`.

This meant they would override the `PAGESERVER_DEFAULT_TENANT_CONFIG_COMPACTION_ALGORITHM`,
impacting our matrix build for `compaction_algorithm=Tiered|Legacy` in
#7748.

I found the tests fixed in this PR using the
`NEON_PAGESERVER_PANIC_ON_UNSPECIFIED_COMPACTION_ALGORITHM` env var that
I added in #7748. Therefore, I think this is an exhaustive fix.
This is better than just searching the code base for `tenant_config`,
which is what I had sketched in #7747.

refs #7749
problame added a commit that referenced this issue May 15, 2024
@problame
test_suite: patch, don't replace, the tenant_config field, where ap…
58dd99c 
…propriate

Before this PR, the changed tests would overwrite the entire
`tenant_config` because `pageserver_config_override` is merged
non-recursively into the `ps_cfg`.

This meant they would override the `PAGESERVER_DEFAULT_TENANT_CONFIG_COMPACTION_ALGORITHM`,
impacting our matrix build for `compaction_algorithm=Tiered|Legacy` in
#7748.

I found the tests fixed in this PR using the
`NEON_PAGESERVER_PANIC_ON_UNSPECIFIED_COMPACTION_ALGORITHM` env var that
I added in #7748. Therefore, I think this is an exhaustive fix.
This is better than just searching the code base for `tenant_config`,
which is what I had sketched in #7747.

refs #7749
@problame problame mentioned this issue May 15, 2024
Merged
problame added a commit that referenced this issue May 17, 2024
@problame
test_suite: patch, don't replace, the tenant_config field, where ap…
6d951e6 
…propriate (#7771)

Before this PR, the changed tests would overwrite the entire
`tenant_config` because `pageserver_config_override` is merged
non-recursively into the `ps_cfg`.

This meant they would override the
`PAGESERVER_DEFAULT_TENANT_CONFIG_COMPACTION_ALGORITHM`, impacting our
matrix build for `compaction_algorithm=Tiered|Legacy` in
#7748.

I found the tests fixed in this PR using the
`NEON_PAGESERVER_PANIC_ON_UNSPECIFIED_COMPACTION_ALGORITHM` env var that
I added in #7748. Therefore, I think this is an exhaustive fix. This is
better than just searching the code base for `tenant_config`, which is
what I had sketched in #7747.

refs #7749
a-masterov pushed a commit that referenced this issue May 20, 2024
@problame @a-masterov
test_suite: patch, don't replace, the tenant_config field, where ap…
85fd31a 
…propriate (#7771)

Before this PR, the changed tests would overwrite the entire
`tenant_config` because `pageserver_config_override` is merged
non-recursively into the `ps_cfg`.

This meant they would override the
`PAGESERVER_DEFAULT_TENANT_CONFIG_COMPACTION_ALGORITHM`, impacting our
matrix build for `compaction_algorithm=Tiered|Legacy` in
#7748.

I found the tests fixed in this PR using the
`NEON_PAGESERVER_PANIC_ON_UNSPECIFIED_COMPACTION_ALGORITHM` env var that
I added in #7748. Therefore, I think this is an exhaustive fix. This is
better than just searching the code base for `tenant_config`, which is
what I had sketched in #7747.

refs #7749
@problame
Copy link
Contributor Author

problame commented Sep 2, 2024

Closing this because the parent epic is paused/abandoned/stale.

@problame problame closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@problame problame

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@problame