Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate delete tombstones over metadata keyspace #7800

Closed
skyzh opened this issue May 17, 2024 · 1 comment · Fixed by #7900
Closed

investigate delete tombstones over metadata keyspace #7800

skyzh opened this issue May 17, 2024 · 1 comment · Fixed by #7900
Labels
c/storage/pageserver Component: storage: pageserver t/bug Issue Type: Bug triaged bugs that were already triaged

Comments

@skyzh
Copy link
Member

skyzh commented May 17, 2024

For now, we assume empty value is tombstones, and we keep the removed metadata keys during compaction for now. Need to sit down and read the code to ensure having such tombstones is safe, and we can remove tombstones during compactions.
@skyzh skyzh added t/bug Issue Type: Bug c/storage/pageserver Component: storage: pageserver labels May 17, 2024
This was referenced May 17, 2024
Merged
Closed
@jcsp
Copy link
Collaborator

jcsp commented May 23, 2024

Action: writing tests to make sure this (small) change is safe.

@jcsp jcsp added the triaged bugs that were already triaged label May 23, 2024
@skyzh skyzh mentioned this issue May 28, 2024
Merged
5 tasks
skyzh added a commit that referenced this issue Jun 3, 2024
@skyzh
feat(pageserver): collect aux file tombstones (#7900)
c1f55c1 
close #7800

This is a small change to enable the tombstone -> exclude from image
layer path. Most of the pull request is unit tests.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/storage/pageserver Component: storage: pageserver t/bug Issue Type: Bug triaged bugs that were already triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pageserver): collect aux file tombstones neondatabase/neon
2 participants
@jcsp @skyzh