Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize aux file size metrics on logical size initial calculation #7822

Closed
skyzh opened this issue May 21, 2024 · 0 comments · Fixed by #7958
Closed

initialize aux file size metrics on logical size initial calculation #7822

skyzh opened this issue May 21, 2024 · 0 comments · Fixed by #7958
Labels
c/storage/pageserver Component: storage: pageserver

Comments

@skyzh
Copy link
Member

skyzh commented May 21, 2024

Currently, the aux file size metrics is an approximation that only gets updated on basebackup and when new aux files are written. If a page server restarts and the user never gets a basebackup, there will be no metrics. One proposal is to initialize aux file size metrics on logical size initial calculation.
@skyzh skyzh added the c/storage/pageserver Component: storage: pageserver label May 21, 2024
@skyzh skyzh mentioned this issue May 21, 2024
Closed
24 tasks
@skyzh skyzh mentioned this issue Jun 4, 2024
Merged
5 tasks
skyzh added a commit that referenced this issue Jun 4, 2024
@skyzh
feat(pageserver): compute aux file size on initial logical size calcu…
1a8d53a 
…lation (#7958)

close #7822
close #7443

Aux file metrics is computed incrementally. If the size is not
initialized, the metrics will never show up. This pull request adds the
functionality to compute the aux file size on initial logical size
calculation.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/storage/pageserver Component: storage: pageserver
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pageserver): compute aux file size on initial logical size calculation neondatabase/neon
1 participant
@skyzh