Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pageserver: retire aux file v1 #8623

Closed
4 tasks done
skyzh opened this issue Aug 7, 2024 · 5 comments
Closed
4 tasks done

pageserver: retire aux file v1 #8623

skyzh opened this issue Aug 7, 2024 · 5 comments
Assignees
@skyzh
Labels
c/storage/pageserver Component: storage: pageserver

Comments

@skyzh
Copy link
Member

skyzh commented Aug 7, 2024 •
edited
Loading

@skyzh skyzh added the c/storage/pageserver Component: storage: pageserver label Aug 7, 2024
@skyzh skyzh self-assigned this Aug 7, 2024
@skyzh skyzh mentioned this issue Aug 22, 2024
Merged
5 tasks
skyzh added a commit that referenced this issue Aug 22, 2024
@skyzh
feat(pageserver): warn on aux v1 tenants + default to v2 (#8625)
6eb638f 
part of #8623

We want to discover potential aux v1 customers that we might have missed
from the migrations.

## Summary of changes

Log warnings on basebackup, load timeline, and the first put_file.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh
Copy link
Member Author

skyzh commented Aug 26, 2024

will deprecate aux v1 keyspace if there is no warning this week

This was referenced Aug 29, 2024
Closed
Merged
Closed
skyzh added a commit that referenced this issue Sep 4, 2024
@skyzh
fix(pageserver): more information on aux v1 warnings (#8906)
99fa1c3 
Part of #8623

## Summary of changes

It seems that we have tenants with aux policy set to v1 but don't have
any aux files in the storage. It is still safe to force migrate them
without notifying the customers. This patch adds more details to the
warning to identify the cases where we have to reach out to the users
before retiring aux v1.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh
Copy link
Member Author

skyzh commented Sep 30, 2024

we have a single user left in prod, need reach out

@skyzh skyzh mentioned this issue Oct 16, 2024
Merged
5 tasks
@skyzh
Copy link
Member Author

skyzh commented Oct 17, 2024

all users migrated, start dropping the code path

skyzh added a commit that referenced this issue Oct 17, 2024
@skyzh
refactor(pageserver): remove aux v1 code path (#9424)
63b3491 
Part of the aux v1 retirement
#8623

## Summary of changes

Remove write/read path for aux v1, but keeping the config item and the
index part field for now.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh
Copy link
Member Author

skyzh commented Oct 21, 2024

this week: if everything goes fine, remove the config item and retire the whole code path + alerts

@skyzh skyzh mentioned this issue Oct 23, 2024
Merged
5 tasks
@skyzh
Copy link
Member Author

skyzh commented Oct 28, 2024

this week: merge #9494

skyzh added a commit that referenced this issue Oct 28, 2024
@skyzh
refactor(pageserver): remove aux v1 configs (#9494)
57c21af 
## Problem

Part of #8623

## Summary of changes

Removed all aux-v1 config processing code. Note that we persisted it
into the index part file, so we cannot really remove the field from
index part. I also kept the config item within the tenant config, but we
will not read it any more.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skyzh skyzh

Labels
c/storage/pageserver Component: storage: pageserver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skyzh