Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no unpinned buffers available in test_pg_regress #9956

Closed
jcsp opened this issue Dec 1, 2024 · 4 comments · Fixed by #9969
Closed

no unpinned buffers available in test_pg_regress #9956

jcsp opened this issue Dec 1, 2024 · 4 comments · Fixed by #9969
Labels
a/test Area: related to testing c/compute Component: compute, excluding postgres itself

Comments

@jcsp
Copy link
Collaborator

jcsp commented Dec 1, 2024

Appears to be intermittent, don't know how frequent.

https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9952/12089734169/index.html#/testresult/25043b524b83a7d9

--- /__w/neon/neon/vendor/postgres-v17/src/test/regress/expected/box.out	2024-11-29 19:35:59.843130233 +0000
+++ /tmp/test_output/test_pg_regress[release-pg17-4]-1/regress/results/box.out	2024-11-29 19:40:57.502895717 +0000
@@ -497,6 +497,7 @@
   (11004, '((-infinity,100),(-infinity,500))'),
   (11005, '((-infinity,-infinity),(700,infinity))');
 CREATE INDEX quad_box_tbl_idx ON quad_box_tbl USING spgist(b);
+ERROR:  no unpinned buffers available
@jcsp jcsp added a/test Area: related to testing c/compute Component: compute, excluding postgres itself labels Dec 1, 2024
@jcsp
Copy link
Collaborator Author

jcsp commented Dec 1, 2024

@ololobus maybe a result of how we run with very few shared buffers in tests?

@knizhnik
Copy link
Contributor

knizhnik commented Dec 1, 2024

For LFC runs we reduce size of shared buffers from 1Mb to 512kB.
I have suggested boot to do it.

@ololobus
Copy link
Member

ololobus commented Dec 2, 2024

For LFC runs we reduce size of shared buffers from 1Mb to 512kB.
I have suggested boot to do it.

@knizhnik what's the value you would recommend for this test? What should be the default?

@knizhnik
Copy link
Contributor

knizhnik commented Dec 2, 2024

For LFC runs we reduce size of shared buffers from 1Mb to 512kB.
I have suggested boot to do it.

@knizhnik what's the value you would recommend for this test? What should be the default?

1Mb - as we have used before and using now for configuration without LFC.

ololobus added a commit that referenced this issue Dec 2, 2024
Everything smaller might be not enough for Postgres under load,
and can cause errors like 'no unpinned buffers available'.

See Konstantin's comment [1] as well.

Fixes #9956

[1]: #9956 (comment)
github-merge-queue bot pushed a commit that referenced this issue Dec 2, 2024
## Problem

After enabling LFC in tests and lowering `shared_buffers` we started
having more problems with `test_pg_regress`.

## Summary of changes

Set `shared_buffers` to 1MB to both exercise getPage requests/LFC, and
still have enough room for Postgres to operate. Everything smaller might
be not enough for Postgres under load, and can cause errors like 'no
unpinned buffers available'.

See Konstantin's comment [1] as well.

Fixes #9956

[1]:
#9956 (comment)
awarus pushed a commit that referenced this issue Dec 5, 2024
## Problem

After enabling LFC in tests and lowering `shared_buffers` we started
having more problems with `test_pg_regress`.

## Summary of changes

Set `shared_buffers` to 1MB to both exercise getPage requests/LFC, and
still have enough room for Postgres to operate. Everything smaller might
be not enough for Postgres under load, and can cause errors like 'no
unpinned buffers available'.

See Konstantin's comment [1] as well.

Fixes #9956

[1]:
#9956 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/test Area: related to testing c/compute Component: compute, excluding postgres itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants