Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage_controller: increase shard scan timeout #10000

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Dec 4, 2024

Problem

The node shard scan timeout of 1 second is a bit too aggressive, and we've seen this cause test failures. The scans are performed in parallel across nodes, and the entire operation has a 15 second timeout.

Resolves #9801.

Summary of changes

Increase the timeout to 5 seconds. This is still enough to time out on a network failure and retry successfully within 15 seconds.

@erikgrinaker erikgrinaker requested a review from a team as a code owner December 4, 2024 10:23
@erikgrinaker erikgrinaker requested a review from problame December 4, 2024 10:23
Copy link

github-actions bot commented Dec 4, 2024

7029 tests run: 6721 passed, 0 failed, 308 skipped (full report)


Flaky tests (9)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 30.8% (8265 of 26844 functions)
  • lines: 47.8% (65177 of 136378 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e7e00f8 at 2024-12-04T11:30:55.583Z :recycle:

@erikgrinaker erikgrinaker added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit db79304 Dec 5, 2024
84 checks passed
@erikgrinaker erikgrinaker deleted the erik/scan-shard-timeout branch December 5, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_cli_start_stop instability
2 participants