Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: add disk consistent and remote lsn metrics #10005

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

VladLazar
Copy link
Contributor

@VladLazar VladLazar commented Dec 4, 2024

Problem

There's no metrics for disk consistent LSN and remote LSN. This stuff is useful when looking at ingest performance.

Summary of changes

Two per timeline metrics are added: pageserver_disk_consistent_lsn and pageserver_projected_remote_consistent_lsn. I went for the projected remote lsn instead of the visible one
because that more closely matches remote storage write tput. Ideally we would have both, but these metrics are expensive.

@VladLazar VladLazar changed the title Vlad/ingest metrics pageserver: add disk consistent and remote lsn metrics Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

6400 tests run: 6110 passed, 0 failed, 290 skipped (full report)


Flaky tests (1)

Postgres 16

Code coverage* (full report)

  • functions: 31.5% (8328 of 26475 functions)
  • lines: 47.8% (65454 of 136924 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4f74ea9 at 2024-12-05T19:40:11.653Z :recycle:

@VladLazar VladLazar marked this pull request as ready for review December 4, 2024 18:58
@VladLazar VladLazar requested a review from a team as a code owner December 4, 2024 18:58
@VladLazar VladLazar requested a review from problame December 4, 2024 18:58
Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per-timeline metrics need to be cleaned up. Actually, some tests should be failing with the current state of the PR because there's not enough cleanup

pageserver/src/metrics.rs Show resolved Hide resolved
pageserver/src/tenant/timeline.rs Show resolved Hide resolved
pageserver/src/tenant/remote_timeline_client.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in expectation that #10005 (comment) will be addressed

@VladLazar VladLazar added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 3f1c542 Dec 6, 2024
82 checks passed
@VladLazar VladLazar deleted the vlad/ingest-metrics branch December 6, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants