-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pageserver: add disk consistent and remote lsn metrics #10005
Conversation
6400 tests run: 6110 passed, 0 failed, 290 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
4f74ea9 at 2024-12-05T19:40:11.653Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per-timeline metrics need to be cleaned up. Actually, some tests should be failing with the current state of the PR because there's not enough cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving in expectation that #10005 (comment) will be addressed
Problem
There's no metrics for disk consistent LSN and remote LSN. This stuff is useful when looking at ingest performance.
Summary of changes
Two per timeline metrics are added:
pageserver_disk_consistent_lsn
andpageserver_projected_remote_consistent_lsn
. I went for the projected remote lsn instead of the visible onebecause that more closely matches remote storage write tput. Ideally we would have both, but these metrics are expensive.