Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(deploy): create git tags/releases before triggering deploy workflows #10022

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

jcgruenhage
Copy link
Member

Problem

When dev deployments are disabled (or fail), the tags for releases aren't created. It makes more sense to have tag and release creation before the deployment to prevent situations like this.

It is not enough to move the tag creation before the deployment. If the deployment fails, re-running the job isn't possible because the API call to create the tag will fail.

Summary of changes

  • Tag/Release creation now happens before the deployment
  • The two steps for tag and release have been merged into a bigger one
  • There's new checks to ensure the that if the tags/releases already exist as expected, things will continue just fine.

@jcgruenhage jcgruenhage force-pushed the jcgruenhage/tag-before-deploy branch from 4f8e679 to bfa9692 Compare December 5, 2024 13:43
@jcgruenhage jcgruenhage marked this pull request as ready for review December 5, 2024 13:45
@jcgruenhage jcgruenhage requested a review from a team as a code owner December 5, 2024 13:45
Copy link

github-actions bot commented Dec 5, 2024

7092 tests run: 6784 passed, 0 failed, 308 skipped (full report)


Flaky tests (5)

Postgres 17

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 31.4% (8321 of 26471 functions)
  • lines: 47.8% (65386 of 136877 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
bfa9692 at 2024-12-05T16:15:04.623Z :recycle:

Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
I've added an optional comment, feel free to ignore

.github/workflows/build_and_test.yml Show resolved Hide resolved
@jcgruenhage jcgruenhage added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit d7aeca2 Dec 11, 2024
87 checks passed
@jcgruenhage jcgruenhage deleted the jcgruenhage/tag-before-deploy branch December 11, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants