Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_subscriber_synchronous_commit flakiness. #10057

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

arssher
Copy link
Contributor

@arssher arssher commented Dec 9, 2024

6f7aeaa configured LFC for USE_LFC case, but omitted setting shared_buffers for non USE_LFC, causing flakiness.

ref #9989

6f7aeaa configured LFC for USE_LFC case, but omitted setting
shared_buffers for non USE_LFC, causing flakiness.

ref #9989
@arssher arssher requested a review from bayandin December 9, 2024 12:12
@bayandin bayandin requested a review from a-masterov December 9, 2024 12:14
Copy link

github-actions bot commented Dec 9, 2024

7766 tests run: 7435 passed, 0 failed, 331 skipped (full report)


Flaky tests (5)

Postgres 17

Postgres 15

Code coverage* (full report)

  • functions: 31.3% (8377 of 26760 functions)
  • lines: 47.7% (65927 of 138291 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
8a90c53 at 2024-12-12T11:55:27.059Z :recycle:

Copy link
Contributor

@a-masterov a-masterov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arssher arssher added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit c9a773a Dec 12, 2024
84 checks passed
@arssher arssher deleted the flaky-test_subscriber_synchronous_commit branch December 12, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants