Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walproposer: fix link error on debian 12 / ubuntu 22 #10090

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

myrrc
Copy link
Contributor

@myrrc myrrc commented Dec 11, 2024

Problem

Linking walproposer library (e.g. cargo t) produces linker errors:
/home/myrrc/neon/pgxn/neon/walproposer_compat.c:169: undefined reference to `pg_snprintf'

The library with these symbols (libpgcommon.a) is present

Summary of changes

Changed order of libraries resolution for linker

@myrrc myrrc requested a review from petuhovskiy December 11, 2024 14:40
@myrrc myrrc added this pull request to the merge queue Dec 11, 2024
Copy link

7073 tests run: 6758 passed, 0 failed, 315 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 16

Postgres 15

Code coverage* (full report)

  • functions: 31.4% (8341 of 26534 functions)
  • lines: 47.7% (65723 of 137703 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
17f0b49 at 2024-12-11T16:24:48.231Z :recycle:

Merged via the queue into main with commit dee2041 Dec 11, 2024
83 checks passed
@myrrc myrrc deleted the walproposer-link-err branch December 11, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants