Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storcon: allow for more concurrency in drain/fill operations #10093

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

VladLazar
Copy link
Contributor

@VladLazar VladLazar commented Dec 11, 2024

Problem

We saw the drain/fill operations not drain fast enough in ap-southeast.

Summary of changes

These are some quick changes to speed it up:

  • double reconcile concurrency - this is now half of the available reconcile bandwidth
  • reduce the waiter polling timeout - this way we can spawn new reconciliations faster

@VladLazar VladLazar marked this pull request as ready for review December 11, 2024 17:12
@VladLazar VladLazar requested a review from a team as a code owner December 11, 2024 17:12
@VladLazar VladLazar requested a review from jcsp December 11, 2024 17:12
@VladLazar VladLazar enabled auto-merge December 11, 2024 18:30
@VladLazar VladLazar added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit e839580 Dec 11, 2024
81 checks passed
@VladLazar VladLazar deleted the vlad/more-concurrent-background-ops branch December 11, 2024 19:45
Copy link

7716 tests run: 7397 passed, 0 failed, 319 skipped (full report)


Flaky tests (8)

Postgres 17

Postgres 16

  • test_pageserver_gc_compaction_smoke: release-x86-64
  • test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64

Postgres 14

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-x86-64

Code coverage* (full report)

  • functions: 31.4% (8342 of 26534 functions)
  • lines: 47.7% (65726 of 137710 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
1940d8c at 2024-12-11T19:47:49.879Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants