Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proxy): remove code for old API #10109

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

conradludgate
Copy link
Contributor

Problem

Now that https://github.com/neondatabase/cloud/issues/15245 is done, we can remove the old code.

Summary of changes

Removes support for the ManagementV2 API, in favour of the ProxyV1 API.

@conradludgate conradludgate requested a review from a team as a code owner December 12, 2024 10:18
Copy link
Contributor

@awarus awarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

By the way, is it fine to merge it before removing old proxy tests from the cloud, or should we remove them there first?

@conradludgate
Copy link
Contributor Author

All tests should be directly interfacing with cplane, or going via proxy that you've already changed to point to proxyv1 api, so I think this should be fine? We can remove the endpoints from cplane at a later time.

Copy link
Contributor

@cloneable cloneable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure why the new auth method already needs an alias.

Copy link

7740 tests run: 7409 passed, 0 failed, 331 skipped (full report)


Flaky tests (3)

Postgres 16

Postgres 15

Code coverage* (full report)

  • functions: 31.4% (8374 of 26700 functions)
  • lines: 47.8% (65912 of 137916 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
aa439cd at 2024-12-12T11:55:26.176Z :recycle:

@conradludgate conradludgate added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit e502e88 Dec 12, 2024
85 checks passed
@conradludgate conradludgate deleted the conrad/remove-console-backend branch December 12, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants