fix(pageserver): run psql in thread to avoid blocking #10177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
force-pushed
the
skyzh/non-block-psql
branch
from
c05fd78 to
7f06138
Compare
7095 tests run: 6796 passed, 0 failed, 299 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
ee7d984 at 2024-12-18T18:14:20.780Z :recycle: |
skyzh
force-pushed
the
skyzh/non-block-psql
branch
from
29f6244 to
395cc4a
Compare
jcsp
reviewed
Dec 18, 2024
|
I merged #10185 into this PR to test the combination of the two |
|
seems to work fine? I'll fix the style issue and rerun |
skyzh
force-pushed
the
skyzh/non-block-psql
branch
from
fd8a0ce to
105fe64
Compare
Co-Authored-By: John Spray <john@neon.tech> Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
skyzh
force-pushed
the
skyzh/non-block-psql
branch
from
105fe64 to
ee7d984
Compare
jcsp
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ref #10170
ref #9994
The psql command will block the main thread, causing other async tasks to timeout (i.e., HTTP connect). Therefore, we need to move it to an I/O executor thread.
Summary of changes