Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reload config file on PS reconnect #10204

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

knizhnik
Copy link
Contributor

Problem

See #10184
and
https://neondb.slack.com/archives/C04DGM6SMTM/p1733997259898819

Reloading config file inside parallel worker cause it's termination

Summary of changes

Remove call of HandleMainLoopInterrupts()
Update of page server URL is propagated by postmaster through shared memory and we should not reload config for it.

@knizhnik knizhnik requested review from a team as code owners December 19, 2024 13:58
Copy link
Contributor

@MMeent MMeent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could use more descriptive description - just referencing the issue is a bit too little IMO.

Copy link
Contributor

@hlinnaka hlinnaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, so the HandleMainLoopinterrupts() call was added in commit b989ad1. The same commit added the mechanism where the connection string is kept in shared memory, and updated by postmaster (or any other process). ISTM that the HandleMainLoopinterrupts() call was never necessary, the ReloadConnstring() (later replaced with load_shard_map) that was added to pageserver_connect was sufficient for backends to have the latest connection string. Commit b989ad1 included a regression test, so if that still passes, we're good.

Copy link

7095 tests run: 6797 passed, 0 failed, 298 skipped (full report)


Flaky tests (4)

Postgres 17

  • test_physical_replication_config_mismatch_too_many_known_xids: release-arm64
  • test_sharding_split_failures[failure0]: debug-x86-64

Postgres 16

Postgres 14

Code coverage* (full report)

  • functions: 31.3% (8397 of 26870 functions)
  • lines: 48.0% (66639 of 138946 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
799c4fc at 2024-12-19T14:59:56.659Z :recycle:

@Bodobolero Bodobolero added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 04517c6 Dec 19, 2024
84 checks passed
@Bodobolero Bodobolero deleted the do_not_retload_config_on_ps_reconnect branch December 19, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants