Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: limit number of upload queue tasks #10384

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Jan 14, 2025

Problem

The upload queue can currently schedule an arbitrary number of tasks. This can both spawn an unbounded number of Tokio tasks, and also significantly slow down upload queue scheduling as it's quadratic in number of operations.

Touches #10096.

Summary of changes

Limit the number of inprogress tasks to the remote storage upload concurrency. While this concurrency limit is shared across all tenants, there's certainly no point in scheduling more than this -- we could even consider setting the limit lower, but don't for now to avoid artificially constraining tenants.

Copy link

github-actions bot commented Jan 14, 2025

7304 tests run: 6933 passed, 0 failed, 371 skipped (full report)


Flaky tests (5)

Postgres 17

Postgres 15

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-arm64

Postgres 14

Code coverage* (full report)

  • functions: 32.9% (8145 of 24776 functions)
  • lines: 48.1% (68239 of 141903 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
fcbe2e8 at 2025-01-14T18:01:32.529Z :recycle:

Base automatically changed from erik/upload-reorder to main January 14, 2025 16:32
@erikgrinaker erikgrinaker force-pushed the erik/upload-inprogress-limit branch from 6c43cd6 to fcbe2e8 Compare January 14, 2025 16:50
@erikgrinaker erikgrinaker requested a review from skyzh January 14, 2025 16:58
@erikgrinaker erikgrinaker added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit e58e29e Jan 14, 2025
84 checks passed
@erikgrinaker erikgrinaker deleted the erik/upload-inprogress-limit branch January 14, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants