-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fast import: allow restore to provided connection string #10407
Open
NanoBjorn
wants to merge
31
commits into
main
Choose a base branch
from
cloud-22775-restore-to-connstring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+590
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce_connection_string param)
NanoBjorn
force-pushed
the
cloud-22775-restore-to-connstring
branch
from
January 15, 2025 14:08
70d43af
to
4a8ff6d
Compare
7359 tests run: 6981 passed, 1 failed, 377 skipped (full report)Failures on Postgres 17
Test coverage report is not availableThe comment gets automatically updated with the latest test results
b79e5f5 at 2025-01-21T17:33:24.690Z :recycle: |
2 tasks
…unning postgres if specified
NanoBjorn
force-pushed
the
cloud-22775-restore-to-connstring
branch
from
January 16, 2025 19:08
4a8ff6d
to
0e40544
Compare
NanoBjorn
force-pushed
the
cloud-22775-restore-to-connstring
branch
2 times, most recently
from
January 20, 2025 19:21
32ed28a
to
01604b3
Compare
why not put the restore connection string into the spec? Shouldn't it be encoded the same way as the source string? |
NanoBjorn
force-pushed
the
cloud-22775-restore-to-connstring
branch
from
January 21, 2025 12:53
01604b3
to
6cd4b9c
Compare
NanoBjorn
requested review from
knizhnik and
lubennikovaav
and removed request for
a team
January 21, 2025 13:26
I have done it both ways as with source connection strings, there are tests on both paths as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within https://github.com/neondatabase/cloud/issues/22089 we decided that would be nice to start with import that runs dump-restore into a running compute (more on this here) We could do it by writing another tool or by extending existing
fast_import.rs
, we chose the latter.In this PR, I have added optional
restore_connection_string
as a cli arg and as a part of the json spec. If specified, the script will not run postgres and will just perform restore into provided connection string.TODO:
fn main
a little, take out too verbose stuff to some functionsallow streaming from dump stdout to restore stdinwill do in a separate PRaddress fast import: restore to neondb (not postgres) database #10251 (review)will do in a separate PRtest with custom dbnamewill do in a separate PRtest with s3 + pageserver + fast import binarywill do in a separate PRfast import: basic python test #10271 (comment)will do in a separate PRneondatabase/cloud#22775