Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute_ctl: Parse sk connstring #4809

Merged
merged 3 commits into from
Jul 26, 2023
Merged

compute_ctl: Parse sk connstring #4809

merged 3 commits into from
Jul 26, 2023

Conversation

bojanserafimov
Copy link
Contributor

@bojanserafimov bojanserafimov commented Jul 26, 2023 •
edited
Loading

Fix #4804 (comment)

Also improve some logs that were too verbose with secrets

@bojanserafimov bojanserafimov requested a review from a team as a code owner July 26, 2023 01:54
@bojanserafimov bojanserafimov requested review from tychoish and removed request for a team July 26, 2023 01:54
@bojanserafimov bojanserafimov changed the title Parse sk connstring compute_ctl: Parse sk connstring Jul 26, 2023
@neondatabase neondatabase deleted a comment from github-actions bot Jul 26, 2023
@github-actions
Copy link

github-actions bot commented Jul 26, 2023 •
edited
Loading

1240 tests run: 1188 passed, 0 failed, 52 skipped (full report)

Flaky tests (4)

Postgres 15

  • test_crafted_wal_end[last_wal_record_crossing_segment]: debug

Postgres 14

  • test_crafted_wal_end[last_wal_record_xlog_switch_ends_on_page_boundary]: release
  • test_get_tenant_size_with_multiple_branches: release
  • test_metrics_normal_work: release

@bojanserafimov bojanserafimov merged commit 916a587 into main Jul 26, 2023
@bojanserafimov bojanserafimov deleted the parse-sk-connstr branch July 26, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petuhovskiy petuhovskiy petuhovskiy approved these changes

@tychoish tychoish Awaiting requested review from tychoish tychoish was automatically assigned from neondatabase/control-plane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bojanserafimov @petuhovskiy