Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy: retry compute wake in auth #4817

Merged
merged 3 commits into from
Jul 26, 2023
Merged

proxy: retry compute wake in auth #4817

merged 3 commits into from
Jul 26, 2023

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Jul 26, 2023 •
edited
Loading

Problem

wake_compute can fail sometimes but is eligible for retries. We retry during the main connect, but not during auth.

Summary of changes

retry wake_compute during auth flow if there was an error talking to control plane, or if there was a temporary error in waking the compute node

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate requested a review from a team as a code owner July 26, 2023 13:46
@conradludgate conradludgate requested review from piercypixel and removed request for a team July 26, 2023 13:46
@conradludgate conradludgate enabled auto-merge (squash) July 26, 2023 14:21
skyzh
skyzh approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

proxy/src/auth/backend/classic.rs Show resolved Hide resolved
@github-actions
Copy link

1240 tests run: 1186 passed, 0 failed, 54 skipped (full report)

Flaky tests (1)

Postgres 15

  • test_remote_timeline_client_calls_started_metric[local_fs]: release

@conradludgate conradludgate merged commit 231d7a7 into main Jul 26, 2023
@conradludgate conradludgate deleted the proxy/retry-compute-wake-auth branch July 26, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

@piercypixel piercypixel Awaiting requested review from piercypixel piercypixel was automatically assigned from neondatabase/control-plane

@kelvich kelvich Awaiting requested review from kelvich

@petuhovskiy petuhovskiy Awaiting requested review from petuhovskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conradludgate @skyzh