Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compute_ctl): remove stray variable in error message #4823

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

koivunej
Copy link
Member

error is not needed because anyhow will have the cause chain reported anyways.

related to test_neon_cli_basics being flaky, but doesn't actually fix any flakyness, just the obvious stray {e}.

error is not needed because anyhow will have the cause chain reported
anyways.
@koivunej koivunej requested review from a team as code owners July 27, 2023 08:04
@koivunej koivunej requested review from conradludgate and skyzh and removed request for a team July 27, 2023 08:04
@koivunej koivunej enabled auto-merge (squash) July 27, 2023 08:05
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

1240 tests run: 1188 passed, 0 failed, 52 skipped (full report)


Flaky tests (4)

Postgres 15

  • test_forward_compatibility: debug
  • test_single_branch_get_tenant_size_grows: debug
  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITHOUT_RESTART-real_s3-timeline-delete-after-rm-metadata]: debug

Postgres 14

@koivunej koivunej merged commit 3e425c4 into main Jul 27, 2023
@koivunej koivunej deleted the remove_template_from_error branch July 27, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants