Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support isolation level + read only for http batch sql #4830

Merged
merged 8 commits into from
Jul 31, 2023
Merged

support isolation level + read only for http batch sql #4830

merged 8 commits into from
Jul 31, 2023

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jul 27, 2023 •
edited
Loading

Problem

Summary of changes

We will retrieve neon-batch-isolation-level and neon-batch-read-only from the http header, which sets the txn properties. neondatabase/serverless#38 (comment)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh
support isolation level + read only for http batch sql
d1ae944 
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from kelvich July 27, 2023 17:29
@skyzh skyzh requested a review from a team as a code owner July 27, 2023 17:29
@skyzh skyzh requested review from adi-griever and removed request for a team July 27, 2023 17:29
@skyzh
return options in resp
fca573c 
Signed-off-by: Alex Chi Z <chi@neon.tech>
@github-actions
Copy link

github-actions bot commented Jul 27, 2023 •
edited
Loading

1240 tests run: 1188 passed, 0 failed, 52 skipped (full report)

@nicksrandall nicksrandall mentioned this pull request Jul 27, 2023
Merged
@skyzh
snake_case
3e28542 
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from vadim2404 July 28, 2023 14:31
@skyzh skyzh requested review from conradludgate and removed request for adi-griever July 31, 2023 13:32
@skyzh skyzh self-assigned this Jul 31, 2023
skyzh added 3 commits July 31, 2023 12:49
@skyzh
options in header
8870ed8 
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh
add tests, return parsed read_only
a866b32 
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh
fix read-only tests
7d9ccff 
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from conradludgate July 31, 2023 16:58
@skyzh
fix fmt
30ac9fb 
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh enabled auto-merge (squash) July 31, 2023 20:27
@skyzh
fix
c260a61 
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh merged commit 7b6c849 into main Jul 31, 2023
@skyzh skyzh deleted the skyzh/txn-mode branch July 31, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradludgate conradludgate conradludgate approved these changes

@kelvich kelvich Awaiting requested review from kelvich

@vadim2404 vadim2404 Awaiting requested review from vadim2404

Assignees

@skyzh skyzh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skyzh @vadim2404 @conradludgate