Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: demote warnings, fix flakyness #4837

Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix: demote warnings, fix flakyness #4837

merged 2 commits into from
Jul 31, 2023

Conversation

koivunej
Copy link
Member

@koivunej koivunej commented Jul 28, 2023 •
edited
Loading

WARN ... found future (image|delta) layer are not actionable log lines. They don't need to be warnings. info! is enough.

This also fixes some known but not tracked flakyness in test_remote_timeline_client_calls_started_metric.

Closes #3369.
Closes #4473.

@koivunej koivunej requested a review from problame July 28, 2023 18:51
@koivunej koivunej requested review from a team as code owners July 28, 2023 18:51
@koivunej koivunej requested review from lubennikovaav and removed request for a team July 28, 2023 18:51
@koivunej koivunej enabled auto-merge (squash) July 28, 2023 18:54
@github-actions
Copy link

github-actions bot commented Jul 28, 2023 •
edited
Loading

1240 tests run: 1189 passed, 0 failed, 51 skipped (full report)

Flaky tests (5)

Postgres 15

  • test_branch_and_gc: release
  • test_empty_tenant_size: debug
  • test_get_tenant_size_with_multiple_branches: debug
  • test_single_branch_get_tenant_size_grows: debug
  • test_s3_wal_replay[mock_s3]: debug

@koivunej koivunej merged commit 89ee8f2 into main Jul 31, 2023
@koivunej koivunej deleted the demote_warnings_on_future_layers branch July 31, 2023 07:43
@koivunej koivunej mentioned this pull request Aug 24, 2023
Merged
koivunej added a commit that referenced this pull request Aug 24, 2023
@koivunej
internal-devx: pageserver future layers (#5092)
f70871d 
I've personally forgotten why/how can we have future layers during
reconciliation. Adds `#[cfg(feature = "testing")]` logging when we
upload such index_part.json, with a cross reference to where the cleanup
happens.

Latest private slack thread:
https://neondb.slack.com/archives/C033RQ5SPDH/p1692879032573809?thread_ts=1692792276.173979&cid=C033RQ5SPDH

Builds upon #5074. Should had been considered on #4837.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpad-m arpad-m arpad-m approved these changes

@skyzh skyzh skyzh approved these changes

@problame problame Awaiting requested review from problame

@lubennikovaav lubennikovaav Awaiting requested review from lubennikovaav lubennikovaav was automatically assigned from neondatabase/compute

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_remote_storage_upload_queue_retries is flaky Image layer files with LSNs from the future
3 participants
@koivunej @skyzh @arpad-m