Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_compatibility: fix pg_tenant_only_port port collision #4850

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jul 31, 2023

Problem

Compatibility tests fail from time to time due to pg_tenant_only_port port collision (added in #4731)

Ref https://neondb.slack.com/archives/C033RQ5SPDH/p1690798232756869

Summary of changes

  • replace pg_tenant_only_port value in config with new port: e0f1cc4
  • remove old logic, than we don't need anymore: 88fa602
  • unify config overrides: 705a5c5

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin requested review from koivunej and petuhovskiy July 31, 2023 14:17
@github-actions
Copy link

1240 tests run: 1189 passed, 0 failed, 51 skipped (full report)


@bayandin bayandin enabled auto-merge (squash) July 31, 2023 16:58
@bayandin bayandin merged commit 39e458f into main Jul 31, 2023
@bayandin bayandin deleted the bayandin/fix-port-collision branch July 31, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants